Hao Hao has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list ......................................................................
Patch Set 3: (5 comments) The failed test cases ITClientStress.testManyShortClientsGeneratingScanTokens and TestKuduClient.testCloseShortlyAfterOpen are not relevant to this patch. However from a short glance I cannot locate the reason for failures. http://gerrit.cloudera.org:8080/#/c/8041/2/src/kudu/util/sorted_disjoint_interval_list.h File src/kudu/util/sorted_disjoint_interval_list.h: Line 57: typedef std::pair<PointType, bool> Point; > do we still need a traits class if it's just a single point type involved? Done Line 88: return Status::OK(); > this going into the error log will probably never get noticed. Done PS2, Line 95: : : : > is this comparator necessary? I think the default comparator for std::pair< Done Line 108 > style: add {}s around if statement Done PS2, Line 111: > do you need ClosedInterval here? emplace_back already takes a variable leng Done -- To view, visit http://gerrit.cloudera.org:8080/8041 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61a813c047be4882f246eaf404598e7e18fcac87 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
