David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 )
Change subject: WIP [consensus] introduce adding NON_VOTER members ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8138/2/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/8138/2/src/kudu/integration-tests/raft_consensus-itest.cc@416 PS2, Line 416: // Get number of source tablet copy sessions at the specified server. nit: leave one blank line above this, for consistency. http://gerrit.cloudera.org:8080/#/c/8138/2/src/kudu/integration-tests/raft_consensus-itest.cc@3242 PS2, Line 3242: TEST_F(RaftConsensusITest, AddNonVoterReplica) { I think this is a good addition, but that, ultimately we also need to add non_voter replicas to a lot of the other full blown integration tests. possible candidates from the most hardened/tricky ones I'd say are *CrashyNodes* *ChurnyElections* in this itest and linked-list-test. -- To view, visit http://gerrit.cloudera.org:8080/8138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2662d45ad9bb6a4bf325d4202c2ee619ffad02b7 Gerrit-Change-Number: 8138 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 26 Sep 2017 20:56:36 +0000 Gerrit-HasComments: Yes
