Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 )
Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h: http://gerrit.cloudera.org:8080/#/c/8157/2/src/kudu/util/subprocess.h@68 PS2, Line 68: Is mutually exclusive with stream : // disabling and sharing. > What I'm trying to say is that any particular stream may be disabled (i.e. OK I think my confusion was that I was reading this as meaning that after calling this method, stderr couldn't be disabled or shared. Might make it clearer by substituting 'stream' with 'stdout'. -- To view, visit http://gerrit.cloudera.org:8080/8157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d81dee93817c560c1237114fb515facbdb06b1d Gerrit-Change-Number: 8157 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 18:29:06 +0000 Gerrit-HasComments: Yes
