Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 )
Change subject: [catalog manager] introduce replica selector ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8161/2/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/8161/2/src/kudu/master/catalog_manager.h@692 PS2, Line 692: Status BuildLocationsForTablet(const scoped_refptr<TabletInfo>& tablet, > warning: function 'kudu::master::CatalogManager::BuildLocationsForTablet' h Done http://gerrit.cloudera.org:8080/#/c/8161/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8161/2/src/kudu/master/catalog_manager.cc@4110 PS2, Line 4110: } else if (s.IsNotFound()) { > warning: do not use 'else' after 'continue' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/8161/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/8161/2/src/kudu/master/master_service.cc@239 PS2, Line 239: // TODO: once we have catalog data. ACL checks would also go here, probably. > warning: missing username/bug in TODO [google-readability-todo] Done -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 29 Sep 2017 23:13:34 +0000 Gerrit-HasComments: Yes
