Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 )
Change subject: periodic: add one-shot timers ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Overall looks good. Are you going to address TidyBot's feedback? http://gerrit.cloudera.org:8080/#/c/8130/3/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: http://gerrit.cloudera.org:8080/#/c/8130/3/src/kudu/rpc/periodic.cc@61 PS3, Line 61: options_(std::move(options)), > warning: std::move of the variable 'options' of the trivially-copyable type yep, it seems using move() for Options does not much sense. -- To view, visit http://gerrit.cloudera.org:8080/8130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4d9376172d66c92958071d5abbac63d751e41f3 Gerrit-Change-Number: 8130 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 04 Oct 2017 20:54:16 +0000 Gerrit-HasComments: Yes
