Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8204
to look at the new patch set (#2).
Change subject: KUDU-2167: fix C++ client crash due to bad assumption regarding
scan data
......................................................................
KUDU-2167: fix C++ client crash due to bad assumption regarding scan data
The new unit test triggered the crash reliably, though it's probably not the
only way (or perhaps not even the best way) to trigger it.
I also modified the tserver to always populate the scan data fields so that
older clients are also protected. This necessitated an additional change to
how a scanner's "data in open" was computed: the existence of the 'data'
field in the scan response isn't enough. The Java client was already doing
this, so it seems like a reasonable change to make on the C++ side.
Change-Id: If1a8a4e22082cf39710b9f00894f644a0b34234e
---
M src/kudu/client/client-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/tserver/tablet_service.cc
3 files changed, 69 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/8204/2
--
To view, visit http://gerrit.cloudera.org:8080/8204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If1a8a4e22082cf39710b9f00894f644a0b34234e
Gerrit-Change-Number: 8204
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
