Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8245 )
Change subject: KUDU-2048. consensus: only evict unresponsive nodes if remaining voters are viable ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8245/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/8245/1/src/kudu/consensus/consensus_queue.cc@383 PS1, Line 383: auto unreachable_time = now - peer->last_successful_communication_time; > guess we should be clearer as to what "viable" is, agreed that slow but res How about requiring a strict majority of the peers not being evicted to have a copy of queue_state_.committed_index? This is supposed to be about safety, not availability or we've exceeded some eviction timeout threshold. The latter already has logic elsewhere, so I'm not convinced of the value of comparing timestamps here. -- To view, visit http://gerrit.cloudera.org:8080/8245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I673f5b8a58b3954ea28066ecb334b3fdd60e7adb Gerrit-Change-Number: 8245 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 10 Oct 2017 19:26:34 +0000 Gerrit-HasComments: Yes
