Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8219 )
Change subject: KUDU-2055 [part 4]: refactor BM to remove BlockManager::DeleteBlock ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8219/3/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/8219/3/src/kudu/fs/block_manager-test.cc@974 PS3, Line 974: Status s = deletion_transaction->CommitDeletedBlocks(&deleted); Could drop "Status s =". And/or wrap the whole thing in ignore_result(). http://gerrit.cloudera.org:8080/#/c/8219/3/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/8219/3/src/kudu/tools/tool_action_fs.cc@172 PS3, Line 172: if (deleted_set.find(entry.block_id) != deleted_set.end()) entry.repaired = true; Use ContainsKey() from map-util.h instead. -- To view, visit http://gerrit.cloudera.org:8080/8219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2ab44f33bce29706f8f41acc3d468582edad6e Gerrit-Change-Number: 8219 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 11 Oct 2017 18:39:12 +0000 Gerrit-HasComments: Yes
