Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8162 to look at the new patch set (#7). Change subject: KUDU-2055 [part 5]: Coalesce hole punch for LBM ...................................................................... KUDU-2055 [part 5]: Coalesce hole punch for LBM This patch extends the implementation of BlockDeletionTransaction to actually coalesce hole punch in LBM, so that blocks in one container that are contiguous are grouped together in a hole punch operation. It also adds a new metric 'holes_punched' in log block manager to track the number of hole punching operations. And another two metrics 'blocks_created' and 'blocks_deleted' in block manager to track blocks that were created and deleted since service start respectively. It updates unit test LogBlockManagerTest.MetricsTest, to verify that coalescing hole punching works as expected by checking the value of 'holes_punched' metric. Change-Id: I7ccc9538b8184f8f7ba8f6118713b82fef433275 --- M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager_metrics.cc M src/kudu/fs/block_manager_metrics.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/util/metrics.cc M src/kudu/util/metrics.h 9 files changed, 424 insertions(+), 184 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8162/7 -- To view, visit http://gerrit.cloudera.org:8080/8162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7ccc9538b8184f8f7ba8f6118713b82fef433275 Gerrit-Change-Number: 8162 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins