Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8392 )
Change subject: KUDU-1961: enable ccache when using devtoolset-3 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8392/1/build-support/enable_devtoolset_inner.sh File build-support/enable_devtoolset_inner.sh: http://gerrit.cloudera.org:8080/#/c/8392/1/build-support/enable_devtoolset_inner.sh@30 PS1, Line 30: export CC="$ROOT/ccache-devtoolset-3/cc" > hrm.. the enable_devtoolset.sh wrapper seems to support any version of devt Isn't enable_devtoolset.sh hard-coded to devtoolset-3? It does "scl enable devtoolset-3 $*" right now. In any case, the problem with supporting a generic devtoolset isn't really with these two; it's with the ccache helper scripts. As best I can tell cmake and autotools expect the compiler to be just an absolute path to a binary. This means we can't use a parameter to select a particular devtoolset. We could potentially use links as a way to have one ccache helper script for multiple devtoolsets, but if cmake/autotools canonicalize the compiler binary, a symbolic link name (which would dictate which devtoolset to use) would be lost. Hard links are a possibility, but now we're entering crazy town. -- To view, visit http://gerrit.cloudera.org:8080/8392 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3a264fc9471e6486a3f17475697f1fa7b64a943 Gerrit-Change-Number: 8392 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2017 20:51:07 +0000 Gerrit-HasComments: Yes
