Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 )
Change subject: [java client] improve AsyncKuduScanner logging ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8382/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/8382/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@727 PS3, Line 727: ret += ", lastPrimaryKey = " + Bytes.pretty(lastPrimaryKey); > I'd lean on the side of not exposing it, since it's somewhat complicated to Ok, then will remove it. As on the other hand, hashed lastPrimaryKey can only give very limited information. -- To view, visit http://gerrit.cloudera.org:8080/8382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90ffcd01e7f99f3090fa118092fc303e06fb92dc Gerrit-Change-Number: 8382 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 30 Oct 2017 23:24:12 +0000 Gerrit-HasComments: Yes
