Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8536 to look at the new patch set (#2). Change subject: KUDU-2215. kernel_stack_watchdog: avoid blocking thread exit ...................................................................... KUDU-2215. kernel_stack_watchdog: avoid blocking thread exit This changes the stack watchdog so that thread unregistration no longer blocks if the watchdog thread is in the middle of dumping a stack. This is to try to avoid cases where a user thread is waiting to join on another thread, but that thread is blocked due to watchdog interference. A new stress-test/benchmark verifies the improvement. It simulates slow stack trace collection by injecting latency into the watchdog thread, and then starts and joins threads in a loop for 5 seconds. Without the fix, it was only able to start about 1000 threads/second, whereas with the fix it's able to start 10,000 threads/second. Change-Id: Ib6a349666e8484c00b2f43c5918205ec1a4c09ab --- M src/kudu/util/fault_injection.cc M src/kudu/util/fault_injection.h M src/kudu/util/kernel_stack_watchdog.cc M src/kudu/util/kernel_stack_watchdog.h M src/kudu/util/stack_watchdog-test.cc 5 files changed, 145 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/8536/2 -- To view, visit http://gerrit.cloudera.org:8080/8536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib6a349666e8484c00b2f43c5918205ec1a4c09ab Gerrit-Change-Number: 8536 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot