Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8567 )
Change subject: catalog_manager_tsk-itest: ensure that test eventually makes progress ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Thank you for fixing the flake. It was more stable when we use separate threads for sending Raft heartbeats. I did a couple updates on the test, increasing the HB interval, so the test became stable. However, I rolled that back with 9c1997a after fix for KUDU-2149 was committed, just to have this test as a canary for such things like KUDU-2149. I think this fix definitely is more comprehensive approach compared with just increasing Raft HB interval. http://gerrit.cloudera.org:8080/#/c/8567/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8567/1//COMMIT_MSG@10 PS1, Line 10: but : sometimes worked so well that the test never made progress and couldn't : obtain a stable leader long enough to create a table lol :) http://gerrit.cloudera.org:8080/#/c/8567/1/src/kudu/integration-tests/catalog_manager_tsk-itest.cc File src/kudu/integration-tests/catalog_manager_tsk-itest.cc: http://gerrit.cloudera.org:8080/#/c/8567/1/src/kudu/integration-tests/catalog_manager_tsk-itest.cc@18 PS1, Line 18: #include <stdlib.h> nit: maybe, replace with <cstdlib> and put along with the rest of C++ headers? -- To view, visit http://gerrit.cloudera.org:8080/8567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ecda0c269225e7674bc384fee652576b110ae7b Gerrit-Change-Number: 8567 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 16 Nov 2017 06:36:59 +0000 Gerrit-HasComments: Yes
