Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8560 )
Change subject: KUDU-1454 [part 2]: enable scan locality for Spark ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8560/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/8560/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@52 PS1, Line 52: val SCAN_LOCALITY = "kudu.scanLocality" Should this take CLOSEST/LEADER_ONLY instead of a bool so that we might add more in the future? -- To view, visit http://gerrit.cloudera.org:8080/8560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f0ea53c2c15ca05da141ff1763018854b84fcea Gerrit-Change-Number: 8560 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 Nov 2017 19:52:22 +0000 Gerrit-HasComments: Yes