Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8563 )
Change subject: KUDU-1078. Fix 'ops in future' error under load ...................................................................... Patch Set 2: (3 comments) Nice, I wasn't sure of the cause of this warning. http://gerrit.cloudera.org:8080/#/c/8563/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8563/2//COMMIT_MSG@12 PS2, Line 12: nit: extra space http://gerrit.cloudera.org:8080/#/c/8563/2/src/kudu/consensus/log_cache-test.cc File src/kudu/consensus/log_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/8563/2/src/kudu/consensus/log_cache-test.cc@381 PS2, Line 381: atomic<bool> stop { false }; nit: Perhaps we should add: if (!AllowSlowTests()) return; http://gerrit.cloudera.org:8080/#/c/8563/2/src/kudu/consensus/log_cache-test.cc@399 PS2, Line 399: . nit: extra period -- To view, visit http://gerrit.cloudera.org:8080/8563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie062adcc7fcaa48f09bbe382267d8f755353a443 Gerrit-Change-Number: 8563 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 16 Nov 2017 22:25:40 +0000 Gerrit-HasComments: Yes
