Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 )
Change subject: tablet: introduce closed mvcc and stopped tablets ...................................................................... Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/7439/32/src/kudu/tablet/tablet.cc@1389 PS32, Line 1389: maintenance_ops_.swap(maintenance_ops); : } is this sufficient protection here for this method? My worry is that, if you call Stop() while you are in the middle of registering the ops, then the ops will still get registered, and Stop() will not cancel or unregister anything. Or is it impossible that RegisterMaintenanceOps will end up called concurrently with a shutdown because of higher level synchronization? Maybe we should add a DFAKE_MUTEX for 'maintenace_ops_lock' and not use lock_, if we are relying on external synchronization? -- To view, visit http://gerrit.cloudera.org:8080/7439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I983620f27e7226806a2cca253db7619731914d42 Gerrit-Change-Number: 7439 Gerrit-PatchSet: 33 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2017 04:36:20 +0000 Gerrit-HasComments: Yes
