Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8700 )
Change subject: [security] Make the kerberos principal configurable for Kudu servers ...................................................................... Patch Set 2: (2 comments) looks good, just a few small nits. http://gerrit.cloudera.org:8080/#/c/8700/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8700/2//COMMIT_MSG@12 PS2, Line 12: sercurity security http://gerrit.cloudera.org:8080/#/c/8700/2/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/8700/2/src/kudu/security/init.cc@383 PS2, Line 383: string p = in_principal; I think you can skip this local copy altogether by using in_prinicipal and out_principal instead, as appropriate. -- To view, visit http://gerrit.cloudera.org:8080/8700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd16b3360d8d2df5a609eb897bb9810e662fc695 Gerrit-Change-Number: 8700 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Dec 2017 18:54:08 +0000 Gerrit-HasComments: Yes
