Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8711 )
Change subject: KUDU-2229. consensus: Leader should not start FD ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8711/4/src/kudu/rpc/periodic.h File src/kudu/rpc/periodic.h: http://gerrit.cloudera.org:8080/#/c/8711/4/src/kudu/rpc/periodic.h@144 PS4, Line 144: // Returns true iff the failure detected has been started. FWIW, this comment is wrong: it refers to failure detection rather than to this generic periodic timer system. -- To view, visit http://gerrit.cloudera.org:8080/8711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2ec9c5499e8e4c1659333bd53dd2d7f6dae81f5 Gerrit-Change-Number: 8711 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Wed, 03 Jan 2018 18:51:52 +0000 Gerrit-HasComments: Yes