Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8757 )
Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/8757/12/build-support/jenkins/add_std_out_to_junit.py File build-support/jenkins/add_std_out_to_junit.py: http://gerrit.cloudera.org:8080/#/c/8757/12/build-support/jenkins/add_std_out_to_junit.py@68 PS12, Line 68: Globs for *.gz ands *. xml logs in log_location, then sorts the logs I'm missing a ton of context, but why not run this script out of run-test.sh instead of build-and-test.sh? That way it'll run once per test and the precise gz/xml file pair will be known, right? http://gerrit.cloudera.org:8080/#/c/8757/12/build-support/jenkins/add_std_out_to_junit.py@69 PS12, Line 69: I Comment style nit: you'll find the pronouns "we" and "us" more commonly used than "I" and "me". -- To view, visit http://gerrit.cloudera.org:8080/8757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f4a9a147f29e37e380cb32ff5af43e1290a1a70 Gerrit-Change-Number: 8757 Gerrit-PatchSet: 12 Gerrit-Owner: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 03 Jan 2018 19:07:51 +0000 Gerrit-HasComments: Yes