Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8941 )
Change subject: KUDU-2251: rowset size can overflow int in RowSetInfo ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8941/2/src/kudu/tablet/rowset_info.h File src/kudu/tablet/rowset_info.h: http://gerrit.cloudera.org:8080/#/c/8941/2/src/kudu/tablet/rowset_info.h@86 PS2, Line 86: // Cached version of rowset_->OnDiskDataSizeNoUndos(). > this is caching rs->OnDiskBaseDataSizeWithRedos() right? No, on the 1.5.x branch it's called OnDiskDataSizeNoUndos. It's been renamed on master. -- To view, visit http://gerrit.cloudera.org:8080/8941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.5.x Gerrit-MessageType: comment Gerrit-Change-Id: I598344e22fc1ecbb482bfe85ea3867ddf63963b4 Gerrit-Change-Number: 8941 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 04 Jan 2018 18:42:32 +0000 Gerrit-HasComments: Yes
