Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8946 )
Change subject: Added steps to update HMS after migrating to multiple Kudu masters. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8946/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/8946/1/docs/administration.adoc@382 PS1, Line 382: master-1 Feels a little weird to use the same values as the DNS aliases in the section specifically for if you didn't set the aliases up. Maybe we can make it clear that these are host names by making them something like 'master-1.example.com' etc. or if that's too verbose then maybe just 'host-1' etc. http://gerrit.cloudera.org:8080/#/c/8946/1/docs/administration.adoc@383 PS1, Line 383: PARAM_VALUE = 'old-master'; How about we add "AND PARAM_KEY = 'kudu.master_addresses'" here. In practice, I think this is unlikely to make a difference, but better to be safe. -- To view, visit http://gerrit.cloudera.org:8080/8946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I920930f3e21c69effb8a5afc9c05ba9eb9e5285d Gerrit-Change-Number: 8946 Gerrit-PatchSet: 1 Gerrit-Owner: [email protected] Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 05 Jan 2018 00:41:10 +0000 Gerrit-HasComments: Yes
