Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/8920 )
Change subject: move configuration constants into separate class and make public ...................................................................... Patch Set 1: Sorry, this is definitely my fault for making the commit message very sparse. First, my plan is to first have PR 8921 approved and then to fix the arising merge conflicts and commit message here. My motivation: External applications using the kudu-mapreduce package need to set these configuration properties correctly. Making the keys public means we can use them directly and avoid duplication, inconsistencies, mistakes through typos, and version conflicts when these properties are changed (as already happened in kudu-mapreduce). Concrete example is the hive-kudu SerDe I am working on. I need to copy the table name and master addresses from the table properties to the MR configuration for the KuduTableInput/OutputFormats. I would feel much more comfortable if I could refer to these Constants in the kudu-mapreduce package directly instead of redefining them within my project again. In my experience it is also a common practice to expose Configuration Keys that other applications need to set. e.g. Hive: https://github.com/apache/hive/blob/master/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java Gobblin: https://github.com/apache/incubator-gobblin/blob/master/gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java -- To view, visit http://gerrit.cloudera.org:8080/8920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64f9ae5c2bc21ddaf757530a33642bd18cd774bf Gerrit-Change-Number: 8920 Gerrit-PatchSet: 1 Gerrit-Owner: Clemens Valiente <clemens.valie...@gmail.com> Gerrit-Reviewer: Clemens Valiente <clemens.valie...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 05 Jan 2018 10:18:44 +0000 Gerrit-HasComments: No
