Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8889 )
Change subject: [consensus] add unsafe gflag to bypass "safe to evict" logic ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/8889/4/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8889/4/src/kudu/consensus/quorum_util-test.cc@a454 PS4, Line 454: : : : : : : : : Was this test removed? http://gerrit.cloudera.org:8080/#/c/8889/4/src/kudu/consensus/quorum_util-test.cc@834 PS4, Line 834: : nit: missing space before colon http://gerrit.cloudera.org:8080/#/c/8889/4/src/kudu/consensus/quorum_util.h File src/kudu/consensus/quorum_util.h: http://gerrit.cloudera.org:8080/#/c/8889/4/src/kudu/consensus/quorum_util.h@40 PS4, Line 40: // (this applies to both the current and the result configuration). I don't think this is true, it should only apply to the resulting configuration. -- To view, visit http://gerrit.cloudera.org:8080/8889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f89b6c584296e3da5047475c5c86c4cb1118ad0 Gerrit-Change-Number: 8889 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Sat, 06 Jan 2018 01:36:03 +0000 Gerrit-HasComments: Yes
