Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8885 )
Change subject: KUDU-2233 Add a test case for compactions in the past ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/8885/7/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/8885/7/src/kudu/integration-tests/fuzz-itest.cc@287 PS7, Line 287: it's nit: its http://gerrit.cloudera.org:8080/#/c/8885/7/src/kudu/integration-tests/fuzz-itest.cc@299 PS7, Line 299: DCHECK(last_op); I think CHECK is probably fine here since it's not a perf issue and would make a crash easier to follow http://gerrit.cloudera.org:8080/#/c/8885/7/src/kudu/integration-tests/fuzz-itest.cc@302 PS7, Line 302: while (attempts < max_attempts) { can you use ASSERT_EVENTUALLY for this loop? http://gerrit.cloudera.org:8080/#/c/8885/7/src/kudu/integration-tests/fuzz-itest.cc@1083 PS7, Line 1083: TEST_F(FuzzTest, DISABLED_TestNoCompactionsInThePast) { can you add the JIRA number to a comment here? -- To view, visit http://gerrit.cloudera.org:8080/8885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibf5685897ef7580dd743faac4d68690a25663e4c Gerrit-Change-Number: 8885 Gerrit-PatchSet: 7 Gerrit-Owner: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 09 Jan 2018 20:36:06 +0000 Gerrit-HasComments: Yes
