Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9004 )
Change subject: KUDU-2254: Detect and warn about misusage of KuduContext ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9004/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9004/2//COMMIT_MSG@16 PS2, Line 16: KuduContecx nit: typo http://gerrit.cloudera.org:8080/#/c/9004/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/9004/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@93 PS2, Line 93: private[kudu] val taskContext = TaskContext.get does this field now end up serialized? Given this field isn't marked @transient, and it's a serializable type, I'm guessing it would get serialized into the KuduContext. That said, maybe it's fine because we expect KuduContext to only be serialized on the driver and deserialized on the executor, and in the driver, TaskContext is always null? -- To view, visit http://gerrit.cloudera.org:8080/9004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65a7cd11a14fa8a668079b0d1fcf6ed3a34fb652 Gerrit-Change-Number: 9004 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 11 Jan 2018 23:56:35 +0000 Gerrit-HasComments: Yes
