Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: [WIP]KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8823/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/8823/1/src/kudu/client/client-test.cc@1194 PS1, Line 1194: > rename this test? Done http://gerrit.cloudera.org:8080/#/c/8823/1/src/kudu/client/client-test.cc@1199 PS1, Line 1199: NO_FATALS(InsertTestRows(client_table_.get(), FLAGS_test_scan_num_rows)); : KuduScanner scanner(client_table_.get()); : ASSERT_OK(scanner.SetProjectedColumns({ "key" })); : ASSERT_OK(scanner.Open()); : : ASSERT_TRUE(scanner.HasMoreRows()); : KuduScanBatch batch; : while (scanner.HasMoreRows()) { : ASSERT_OK(scanner.NextBatch(&batch)); : for (const KuduScanBatch::RowPtr& row : batch) { : ASSERT_NE("(int32 key=<redacted>)", row.ToString()); : } : } > this doesn't strike me as a very good test, particularly if we make this mo Added more unit tests for scan with different replica selection, and multi tablets scan. I am planning to add some integration tests. -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 12 Jan 2018 03:58:18 +0000 Gerrit-HasComments: Yes
