Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 )
Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/9015/10/src/kudu/util/os-util.h File src/kudu/util/os-util.h: http://gerrit.cloudera.org:8080/#/c/9015/10/src/kudu/util/os-util.h@27 PS10, Line 27: > should probably #include <errno.h> here since EINTR is defined there Done http://gerrit.cloudera.org:8080/#/c/9015/10/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: http://gerrit.cloudera.org:8080/#/c/9015/10/src/kudu/util/subprocess-test.cc@338 PS10, Line 338: ASSERT_TRUE(err == 0 || err == ESRCH); > nit: I think this would read better as ASSERT_TRUE(err == 0 || err == ESRCH Done http://gerrit.cloudera.org:8080/#/c/9015/10/src/kudu/util/subprocess-test.cc@340 PS10, Line 340: LOG(INFO) << "Async kill signal failed with err=" << err << > can you add an ASSERT_TRUE(t_finished) here? we should only get ESRCH in th Done http://gerrit.cloudera.org:8080/#/c/9015/10/src/kudu/util/subprocess-test.cc@344 PS10, Line 344: // Add microseconds delay to make the unit test runs faster and more reliable > can you change this to rand() % 1? It still runs quickly on my machine with Done -- To view, visit http://gerrit.cloudera.org:8080/9015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I148b4619a8dda8e3e95dd6ea5c6e993a9e37a333 Gerrit-Change-Number: 9015 Gerrit-PatchSet: 12 Gerrit-Owner: Jeffrey F. Lukman <jeffreyfluk...@gmail.com> Gerrit-Reviewer: Jeffrey F. Lukman <jeffreyfluk...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 17 Jan 2018 06:44:32 +0000 Gerrit-HasComments: Yes
