Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 )
Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/test_util.h@115 PS1, Line 115: // Sleep for a millisecond while looping. > nit: it doesn't check every millisecond, but rather sleeps one millisecond Thanks, will clarify. http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/9021/1/src/kudu/util/threadpool.cc@621 PS1, Line 621: SCOPED_CLEANUP({ > can you use the SCOPED_CLEANUP macro instead if you don't need the named va I had been cancelling at one point, then didn't need to anymore but forgot to revert back to SCOPED_CLEANUP. Done. -- To view, visit http://gerrit.cloudera.org:8080/9021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8036bf0d15f9ffcb3fa76579e3bfe0a340d38320 Gerrit-Change-Number: 9021 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 17 Jan 2018 22:30:04 +0000 Gerrit-HasComments: Yes
