Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9117 )
Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9117/1/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9117/1/src/kudu/rpc/rpc-test.cc@592 PS1, Line 592: TEST_P(TestRpc, TestRpcLogging) { hrm, I appreciate the effort of adding a test, but since the test doesn't actually assert anything, and it's just a pretty trivial substitution of a constant to a flag, I don't think it's necessary -- To view, visit http://gerrit.cloudera.org:8080/9117 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie587ee602e83bb65d74f7ee622a9bc47897f2574 Gerrit-Change-Number: 9117 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 24 Jan 2018 18:57:11 +0000 Gerrit-HasComments: Yes
