Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8494 to look at the new patch set (#9). Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling ...................................................................... KUDU-2191 (4/n): HMS Thrift client fault handling This commit improves the new HMS Thrift client's ability to handle faults. In particular: - The client now uses send, receive, and connect timeouts so that a non-responsive HMS instance will not block the client indefinitely. - The Thrift logging callback is hooked up to glog so that we get proper log messages from Thrift. - The HmsClient class and method docs include information about behavior when errors are encountered. In the part 2 review, Todd also brought up the prospect of creating a wrapper Thrift socket or transport to inject slow log warning messages automatically. I've held off doing this for now, because I haven't been able to figure out a way to do that which can associate the slowness with higher-level operations like 'create database', as opposed to lower-level like 'socket write'. I've made sure to apply the slow warning calls uniformly across the HmsClient methods, and I don't think it will be too onerous to keep them consistent in the future. Change-Id: Ic48bbb833bbae39b383ae239054b9710da3c746d --- M src/kudu/hms/hms_client-test.cc M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h M src/kudu/mini-cluster/external_mini_cluster-test.cc 6 files changed, 192 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/8494/9 -- To view, visit http://gerrit.cloudera.org:8080/8494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic48bbb833bbae39b383ae239054b9710da3c746d Gerrit-Change-Number: 8494 Gerrit-PatchSet: 9 Gerrit-Owner: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>