Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8830 )
Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client) ...................................................................... Patch Set 28: (8 comments) LGTM, just a few nits. http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/client/schema.h@244 PS28, Line 244: /// This constructor is private because clients should use the Builder API. : /// : /// @param [in] name : /// The name of the column. : /// @param [in] type : /// The type of the column. : /// @param [in] is_nullable : /// Whether the column is nullable. : /// @param [in] default_value : /// Default value for the column. : /// @param [in] attributes : /// Column storage attributes. nit: usually we don't document private methods since they are not accessible via client API. http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/client/schema.cc@190 PS28, Line 190: delete data_; : data_ = new Data(*other.data_); What if other == *this? http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/common/schema.h File src/kudu/common/schema.h: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/common/schema.h@91 PS28, Line 91: public: nit: it's public by default in struct, no need to specify explicitly http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc File src/kudu/integration-tests/decimal-itest.cc: http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc@52 PS28, Line 52: const int kNumServers = 3; nit: it's 3 tablet server by default, you could drop this. http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc@55 PS28, Line 55: {}, {}, kNumServers nit: I think it's possible to drop all this and use the parameters 'by default' http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc@98 PS28, Line 98: client_->OpenTable(kTableName, &table); nit: ASSERT_OK ? http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc@130 PS28, Line 130: ASSERT_OK(scanner.SetReadMode(KuduScanner::READ_AT_SNAPSHOT)); nit: it's possible to drop this since SetFaultTolerant() set the read mode to READ_AT_SNAPSHOT 'automagically'. http://gerrit.cloudera.org:8080/#/c/8830/28/src/kudu/integration-tests/decimal-itest.cc@172 PS28, Line 172: } nit: would it make sense to add an 'erroneous case' trying to read decimal as, say, float/double/string/ etc.? -- To view, visit http://gerrit.cloudera.org:8080/8830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b06142f43c66973f36376bd2c88ca6f8d9f7632 Gerrit-Change-Number: 8830 Gerrit-PatchSet: 28 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 02 Feb 2018 19:25:00 +0000 Gerrit-HasComments: Yes
