Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9172 )
Change subject: maintenance_manager: log the reason for scheduling each operation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9172/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/9172/1/src/kudu/util/maintenance_manager.cc@444 PS1, Line 444: best performance improvement > It's not just this log that worries me but it's the one that worries me the +1 to making the messages concise, but we should include the memory % in the memory pressure messages, since it's actually hard to know from the logs w/o seeing rejections. -- To view, visit http://gerrit.cloudera.org:8080/9172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dcdb863a7a0b0fc2a72757801d5c057fa725c34 Gerrit-Change-Number: 9172 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 02 Feb 2018 21:25:22 +0000 Gerrit-HasComments: Yes
