Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9233
to review the following change.
Change subject: Fix crash when log_dir is not specified
......................................................................
Fix crash when log_dir is not specified
This fixes the tpch1 benchmark after the recent enabling of metrics
logging. The crash was due to FLAGS_log_dir being unset. In typical
servers, we rely on InitGoogleLoggingSafe to default log_dir to /tmp,
but our tpch1 benchmark embeds a client, and a constructor function in
the client calls InitGoogleLoggingSafeBasic which doesn't do this
defaulting. So, we ended up starting the minicluster with an empty log
dir.
This patch just makes it not start the metrics logger if no log dir is
set.
Change-Id: I725a7da038913ff05227c6d5555c34167138148b
---
M src/kudu/server/server_base.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9233/1
--
To view, visit http://gerrit.cloudera.org:8080/9233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I725a7da038913ff05227c6d5555c34167138148b
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
