Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9257 )
Change subject: Fix client comaptibility with gcc 4.4 ...................................................................... Fix client comaptibility with gcc 4.4 We expect the client lib to work with gcc 4.4 and C++98. When the int128 type was added this broke compatibility because __int128 support didn’t exist until gcc 4.6. To work around this and still allow gcc 4.6+ and C++11 compilation to support int128, a preprocessor check was added to define KUDU_INT128_SUPPORTED which is used to exclude the incompatible client code. Additionally the int128 insertion operator definitions were moved to their own file to ensure they are not required when working with Kudu’s int128 types. This ensures there aren’t compatibily issues with clients that define their own __int128 insertion operator. Change-Id: I59b40a9718b321df1a5878160ac845d4cf3d9170 Reviewed-on: http://gerrit.cloudera.org:8080/9257 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/encoding-test.cc M src/kudu/client/scan_batch.h M src/kudu/client/value.cc M src/kudu/client/value.h M src/kudu/common/key_encoder.h M src/kudu/common/partial_row.h M src/kudu/tools/kudu-tool-test.cc M src/kudu/util/CMakeLists.txt M src/kudu/util/int128-test.cc M src/kudu/util/int128.h R src/kudu/util/int128_util.h 12 files changed, 38 insertions(+), 19 deletions(-) Approvals: Kudu Jenkins: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I59b40a9718b321df1a5878160ac845d4cf3d9170 Gerrit-Change-Number: 9257 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
