Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 )
Change subject: Make tcmalloc heap sampling more useful ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/server/pprof_path_handlers.cc File src/kudu/server/pprof_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/server/pprof_path_handlers.cc@104 PS2, Line 104: message with instructions how to enable it > The message (tcmalloc.cc L592) just mentions the TCMALLOC_SAMPLE_PARAMETER Done http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/util/flags.cc@88 PS2, Line 88: heap_sample_parameter > I know this name matches the one that tcmalloc uses, but I'd like a more de Done http://gerrit.cloudera.org:8080/#/c/9263/2/src/kudu/util/flags.cc@89 PS2, Line 89: N > What's N? I think this would also be fixed with a better name and adjusted Done -- To view, visit http://gerrit.cloudera.org:8080/9263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I939c2f01f17ceb4b9520bb566f66463952b2a255 Gerrit-Change-Number: 9263 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 20:02:46 +0000 Gerrit-HasComments: Yes
