Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8882 )
Change subject: KUDU-721: [Java] Add DECIMAL column type support ...................................................................... Patch Set 14: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/8882/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/8882/14/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@1240 PS14, Line 1240: BigDecimal max = DecimalUtil.maxValue(precision, scale); This is a little bit different than the c++ IncrementCell which is based on the physical type. I don't think this will cause problems, but it's something to keep in mind. -- To view, visit http://gerrit.cloudera.org:8080/8882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6240e3cfe0d6328b68c50099d442ffeeab6c9fd9 Gerrit-Change-Number: 8882 Gerrit-PatchSet: 14 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 13 Feb 2018 22:11:51 +0000 Gerrit-HasComments: Yes
