Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 )
Change subject: KUDU-2031: Add metrics per connection to the reactor metrics ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9343/3/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/9343/3/src/kudu/rpc/connection.cc@662 PS3, Line 662: // Do the transfer and time it. : Stopwatch send_timer; : send_timer.start(); : Status status = transfer->SendBuffer(*socket_); : send_timer.stop(); Not sure how accurate this will be fore inferring throughput given this is non-blocking. Also, will it be sufficient to approximate the Kbps based on the aggregate of all loop iterations instead of doing it per loop iteration ? http://gerrit.cloudera.org:8080/#/c/9343/3/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: http://gerrit.cloudera.org:8080/#/c/9343/3/src/kudu/rpc/transfer.cc@245 PS3, Line 245: if (TransferFinished()) return 0; nit: Not sure if Kudu coding standard allows this kind of one liner. http://gerrit.cloudera.org:8080/#/c/9343/3/src/kudu/rpc/transfer.cc@246 PS3, Line 246: int32_t rem_in_cur_slice = payload_slices_[cur_slice_idx_].size() - cur_offset_in_slice_; : int32_t total_remaining = rem_in_cur_slice; Why not just write int32_t total_remaining = payload_slices_[cur_slice_idx_].size() - cur_offset_in_slice_; -- To view, visit http://gerrit.cloudera.org:8080/9343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae1a5fe0066adf644a9cac41ad6696e1bbf00465 Gerrit-Change-Number: 9343 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 16 Feb 2018 01:32:27 +0000 Gerrit-HasComments: Yes
