Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9355 )
Change subject: KUDU-2305: Fix local variable usage to handle 2GB messages ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9355/3/src/kudu/rpc/serialization.cc File src/kudu/rpc/serialization.cc: http://gerrit.cloudera.org:8080/#/c/9355/3/src/kudu/rpc/serialization.cc@61 PS3, Line 61: static_cast<int64_t>(additional_size) > Won't this be automatically promoted to int64_t ? Is this second cast neede Yes, I think only the first cast is necessary to fix the ASAN issue. This seems like a code style thing, so I thought I'd let the Kudu guys comment. I don't have a preference. http://gerrit.cloudera.org:8080/#/c/9355/3/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: http://gerrit.cloudera.org:8080/#/c/9355/3/src/kudu/rpc/transfer.cc@81 PS3, Line 81: kMsgLengthPrefixLength > Does it make sense to to DCHECK_LE(kMsgLengthPrefixLength, INT_MAX) or in t kMsgLengthPrefixLength is a uint8_t and is always 4, so rem is always a small number. The comment right above this is confusing. I'll see if I can make it clearer. -- To view, visit http://gerrit.cloudera.org:8080/9355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e468099b16f7eb55de71b753acae8f57d18287c Gerrit-Change-Number: 9355 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 17:24:39 +0000 Gerrit-HasComments: Yes
