Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8823 )
Change subject: KUDU-1704: add c++ client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/8823/9/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/8823/9/src/kudu/client/client.h@1740 PS9, Line 1740: /// When @c READ_YOUR_WRITES is specified, the server will pick a timestamp to use I still think there is room to simplify these docs. I would prefer if they didn't mention timestamps _at all_. http://gerrit.cloudera.org:8080/#/c/8823/9/src/kudu/client/client.h@1745 PS9, Line 1745: If no propagated timestamp is provided the server What does this mean in terms of an application developer reading this doc? How would such a developer provide a timestamp? Why would such a developer want to provide a propagated timestamp? -- To view, visit http://gerrit.cloudera.org:8080/8823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34214245a78aed172a28fbdb395ff5bccd0fc0e1 Gerrit-Change-Number: 8823 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 20:51:58 +0000 Gerrit-HasComments: Yes
