Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9343 )
Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9343/5/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/9343/5/src/kudu/rpc/rpc-test.cc@489 PS5, Line 489: controllers.back().get(), boost::bind(&CountDownLatch::CountDown, boost::ref(latch))); > Yes you're right. I can't think of a sure shot way to make sure that we don I still don't think that helps, because the RPCs will still end up read off the wire by the reactor thread and thus won't be pending in the client outbound queue, even if the server is blocked _processing them_. You'd have to somehow block the server's reactor thread so that it isn't reading off the pipe, and then you'd have to fill up the socket's send-buffer so that the client can't make progress sending the transfers to the pipe -- To view, visit http://gerrit.cloudera.org:8080/9343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae1a5fe0066adf644a9cac41ad6696e1bbf00465 Gerrit-Change-Number: 9343 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 20 Feb 2018 21:55:09 +0000 Gerrit-HasComments: Yes
