Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9254 )
Change subject: KUDU-2291 (part 3): use futex to speed up stack collection ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/9254/5/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9254/5/src/kudu/util/debug-util.cc@144 PS5, Line 144: 0 how about: nullptr /* ignored */ http://gerrit.cloudera.org:8080/#/c/9254/5/src/kudu/util/debug-util.cc@197 PS5, Line 197: spins waiting s/spins waiting/waits/ -- To view, visit http://gerrit.cloudera.org:8080/9254 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb772f0607275ec340c7f38be05347fc14820cbd Gerrit-Change-Number: 9254 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 00:37:42 +0000 Gerrit-HasComments: Yes