Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9330 to look at the new patch set (#6). Change subject: KUDU-2297 (part 4): periodically dump stacks to diagnostics log ...................................................................... KUDU-2297 (part 4): periodically dump stacks to diagnostics log This modifies the diagnostics log to periodically dump stack traces. This is slightly complicated by the fact that symbolized stack traces can be relatively large. So, we separate the logging of symbols and stack traces. When an address first appears in a log file, it is logged as part of a symbol line. Later logs of the same address do not need to re-log the symbol. With this, a typical stack trace dump of an idle tserver is about 4KB pre-compression, and a 'symbols' dump is about 6KB. So logging stacks reasonably often should not use much disk space or IO. Currently this is enabled on the same interval as the metrics log, but only if a new experimental flag --diagnostics-log-stack-traces is enabled. I'm planning to move it to a different flag in a later commit, but wanted to keep this one simple and incremental. Change-Id: Ic32abf2c48ac6a5f3c384e58838b34671bcaf147 --- M src/kudu/server/diagnostics_log.cc M src/kudu/server/diagnostics_log.h M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h M src/kudu/util/rolling_log-test.cc M src/kudu/util/rolling_log.cc M src/kudu/util/rolling_log.h 7 files changed, 227 insertions(+), 41 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/9330/6 -- To view, visit http://gerrit.cloudera.org:8080/9330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic32abf2c48ac6a5f3c384e58838b34671bcaf147 Gerrit-Change-Number: 9330 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>