Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9318 )
Change subject: KUDU-2291 (part 5): allow collecting stack traces asynchronously ...................................................................... Patch Set 6: (1 comment) Looks good, there were a couple comments missed in rev 5 http://gerrit.cloudera.org:8080/#/c/9318/4/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9318/4/src/kudu/util/debug-util.cc@219 PS4, Line 219: if (!sig) { > Because we're using the signal data as a sort of queue to move the 'info' p Oops, I figured this out and forgot to delete the comment. Thanks for the explanation though. -- To view, visit http://gerrit.cloudera.org:8080/9318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4d7789bb1272db033df4685f46eaf8483ec7be1 Gerrit-Change-Number: 9318 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 21 Feb 2018 08:00:12 +0000 Gerrit-HasComments: Yes
