Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9373 )
Change subject: KUDU-2319 follower masters should be able to verify authn tokens ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9373/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9373/6/src/kudu/master/catalog_manager.cc@1040 PS6, Line 1040: static const auto kTskRotationInterval = > According to https://stackoverflow.com/questions/55510/when-do-function-lev I agree it's better to be certain here, especially if you feel strong about that. But I'm sure it would work as needed, though. But just for fun, I dig a bit more. And actually, that's true not only for non-POD types: ---- #include <iostream> using namespace std; static int X = 100; void foo() { const static int x = X; cout << x << endl; } int main() { X = 200; foo(); return 0; } ---- But it might depend on the whether X in the same compilation unit, though. In addtioon, MonoDelta is _not_ a POD type because it's not a trivial type: http://en.cppreference.com/w/cpp/language/default_constructor#Trivial_default_constructor Just for fun I decided to check std::is_pod<T>(), and it confirmed MonoDelta not a POD: TEST_F(SecurityITest, IsMonoDeltaPod) { ASSERT_FALSE(std::is_pod<MonoDelta>::value); } ==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SecurityITest [ RUN ] SecurityITest.IsMonoDeltaPod [ OK ] SecurityITest.IsMonoDeltaPod (2 ms) [----------] 1 test from SecurityITest (2 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2 ms total) [ PASSED ] 1 test. -- To view, visit http://gerrit.cloudera.org:8080/9373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idcc92dd4fae3d555af563d86634c07d3d06147a7 Gerrit-Change-Number: 9373 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 23 Feb 2018 23:09:15 +0000 Gerrit-HasComments: Yes
