Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/9444 )
Change subject: [thirdparty] fix gperftools build on Mac OS X
......................................................................
[thirdparty] fix gperftools build on Mac OS X
The recently introduced large-span-search patch didn't comply
with build-time checks enforced by the C++ compiler from the dev
toolchain on Mac OS X version 10.13.2 (a.k.a. High Sierra). The
build error was:
In file included from
thirdparty/src/gperftools-2.6.3/src/central_freelist.cc:36:
In file included from thirdparty/src/gperftools-2.6.3/src/central_freelist.h:45:
In file included from thirdparty/src/gperftools-2.6.3/src/span.h:40:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/set:412:5:
error:
static_assert failed "Allocator::value_type must be same type as
value_type"
static_assert((is_same<typename allocator_type::value_type,
value_type>::value),
This patch fixes the issue.
Change-Id: Iff3e3a5dd50541c8eba48e7e6aa917d649e54931
Reviewed-on: http://gerrit.cloudera.org:8080/9444
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <[email protected]>
Reviewed-by: Will Berkeley <[email protected]>
---
M
thirdparty/patches/gperftools-Implemented-O-log-n-searching-among-large-spans.patch
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
Will Berkeley: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/9444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff3e3a5dd50541c8eba48e7e6aa917d649e54931
Gerrit-Change-Number: 9444
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
