Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9440 )
Change subject: KUDU-2312: Scan predicate application ordering is non-deterministic ...................................................................... Patch Set 4: Whoops sorry I thought I responded to your previous comment but looks like it got lost. > If we changed this to be a std::stable_sort instead of tie-breaking with > index, would we end up retaining the client's predicate order, you think? No, we put the predicates into an hash map, and at that point they lose all ordering (ScanSpec::predicates_). The /scans page is also populated from this unorderd map, so it doesn't reflect the true ordering either. I don't think it's wise to guarantee an ordering externally. Ideally we'd be using our own internal stats to do the predicate evaluation ordering on a per-cfile basis, so there wouldn't even be a consistent global ordering. -- To view, visit http://gerrit.cloudera.org:8080/9440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b2cabecd8626cad7e11fbdd492af7276e08348 Gerrit-Change-Number: 9440 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 03 Mar 2018 02:22:14 +0000 Gerrit-HasComments: No
