Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9503 )
Change subject: build: adjust the number of processors for various tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9503/1/src/kudu/util/test_main.cc File src/kudu/util/test_main.cc: http://gerrit.cloudera.org:8080/#/c/9503/1/src/kudu/util/test_main.cc@78 PS1, Line 78: Stopwatch sw(Stopwatch::ALL_THREADS); > yea, I looked at that, but then the average across the entire test lifetime actually I am now looking at the results of the 'perf stat' experiment (I had it run overnight after I left work) and it seems that it reveals a lot more tests that use more processors than the method in this patch. So I think it's probably worth being accurate here. Makes sense since most of our heavier tests are based on external minicluster and a lot of the CPU is consumed by the tservers, not the client which runs in the test case itself. I'll revert this junk and add an env-var-based method to the test wrapper. -- To view, visit http://gerrit.cloudera.org:8080/9503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I922031af69178b98459d0d59287442b692425afa Gerrit-Change-Number: 9503 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 06 Mar 2018 18:03:52 +0000 Gerrit-HasComments: Yes
