David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9522 )
Change subject: KUDU-1913: cap number of threads on server-wide pools ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9522/1/src/kudu/kserver/kserver.cc File src/kudu/kserver/kserver.cc: http://gerrit.cloudera.org:8080/#/c/9522/1/src/kudu/kserver/kserver.cc@39 PS1, Line 39: server_thread_pool_thread_limit lgtm, only minor nit is the name of the flag server_thread_pool_thread_limit, how about server_thread_pool_max_count or server_thread_pool_max_thread_count ? don't feel super strongly about it so fine by folks like this name. -- To view, visit http://gerrit.cloudera.org:8080/9522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I194907a7f8a483c9cba71eba8caed6bc6090f618 Gerrit-Change-Number: 9522 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 01:15:46 +0000 Gerrit-HasComments: Yes