Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9050 )
Change subject: KUDU-2264. java: automatically attempt to re-acquire Kerberos credentials before expiration ...................................................................... Patch Set 3: (3 comments) I just did a first quick pass. Overall looks good, I'm thinking about re-visiting this patch once more time tonight. http://gerrit.cloudera.org:8080/#/c/9050/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9050/3//COMMIT_MSG@7 PS3, Line 7: java: automatically attempt to re-acquire Kerberos credentials before expiration nit: this looks too long; maybe java: automatically re-acquire Kerberos credentials http://gerrit.cloudera.org:8080/#/c/9050/3//COMMIT_MSG@12 PS3, Line 12: It also adds a long javadoc for AsyncKuduClient indicating the proper : way to authenticate to a secured Kudu cluster for various scenarios, : since this is a common question we've gotten. it's a nice addition http://gerrit.cloudera.org:8080/#/c/9050/3/java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java: http://gerrit.cloudera.org:8080/#/c/9050/3/java/kudu-client/src/main/java/org/apache/kudu/util/SecurityUtil.java@196 PS3, Line 196: principal.getRealm() + "@" + principal.getRealm()) Do we always have the service and the client in the same domain? Maybe, it's better to use some pattern matching here instead? -- To view, visit http://gerrit.cloudera.org:8080/9050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I514253e0a7f067dbc8ffe4eaf5a7a2c32900b539 Gerrit-Change-Number: 9050 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #380 Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 07 Mar 2018 19:57:30 +0000 Gerrit-HasComments: Yes
