Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9541 )
Change subject: Add CatalogManager::master_consensus() accessor ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9541/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/9541/2/src/kudu/master/catalog_manager.cc@3759 PS2, Line 3759: std::lock_guard<LockType> l(lock_); Would shared_lock<LockType> l(lock_) be a better choice here? -- To view, visit http://gerrit.cloudera.org:8080/9541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6887900329e67222da129b4a1b532cfb0a364b4 Gerrit-Change-Number: 9541 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 08 Mar 2018 00:01:42 +0000 Gerrit-HasComments: Yes
